New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2 compat - Fix fatal error #8724

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
5 participants
@enumag
Contributor

enumag commented Feb 2, 2018

Questions Answers
Branch? 1.6.1.x
Description? Fix PHP fatal error.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Try to access admin login page. It might be specific to PHP 7.2.
Fatal error: Declaration of AdminLoginControllerCore::viewAccess() must be compatible with AdminControllerCore::viewAccess($disable = false) in <path>\www\controllers\admin\AdminLoginController.php on line 27

This change is Reviewable

@SebSept

This comment has been minimized.

Contributor

SebSept commented Jun 15, 2018

pull requets already existing : #8760

@Quetzacoalt91 Quetzacoalt91 changed the title from Fix fatal error to PHP 7.2 compat - Fix fatal error Jun 15, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.6.1.20 milestone Jun 15, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 4145b95 into PrestaShop:1.6.1.x Jun 15, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Jun 15, 2018

Thank you @enumag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment