New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO: prefer Hook::coreRenderWidget #8744

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
6 participants
@jherry
Contributor

jherry commented Feb 7, 2018

Questions Answers
Branch? develop
Description? On PS1.7 We should call Hook::coreRenderWidget method to allow developpers of modules to override this behavior. It exists so it must be called here.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? already existing widget tests

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Jun 5, 2018

Contributor

Sadly, this need to be rebased...

Contributor

mickaelandrieu commented Jun 5, 2018

Sadly, this need to be rebased...

CO: prefer Hook::coreRenderWidget
We should call Hook::coreRenderWidget method to allow developpers of modules to override this behavior. It exists so it must be called here.
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 31, 2018

Member

Rebased

Member

Quetzacoalt91 commented Aug 31, 2018

Rebased

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Aug 31, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Aug 31, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit cb1498d into PrestaShop:develop Aug 31, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 31, 2018

Thank you @jherry

@jherry jherry deleted the jherry:patch-1 branch Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment