New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the possibility to create a customer with "¤" or " #8758

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
6 participants
@PierreJoube

PierreJoube commented Feb 13, 2018

Questions Answers
Branch? 1.6.1.x
Description? Fix the possibility to create a customer with "¤" or "
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? backport from http://forge.prestashop.com/browse/BOOM-4817 for 1.6.1.x
How to test? Try to create a front customer with "¤" or "

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Feb 13, 2018

Collaborator

Hello PierreJoube!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Feb 13, 2018

Hello PierreJoube!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@LittleBigDev

This comment has been minimized.

Show comment
Hide comment
@LittleBigDev

LittleBigDev Feb 14, 2018

Contributor

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Contributor

LittleBigDev commented Feb 14, 2018

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@eternoendless eternoendless added this to the 1.6.1.19 milestone Mar 26, 2018

@mickaelandrieu mickaelandrieu added the Bug label Apr 3, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.19, 1.6.1.20 May 24, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.20, 1.6.1.21 Jun 27, 2018

@eternoendless eternoendless changed the title from CO: adding "¤" and "|" to isName() to Adding "¤" and "|" to isName() Sep 24, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Sep 24, 2018

Thank you @PierreJoube

@eternoendless eternoendless merged commit b335ee1 into PrestaShop:1.6.1.x Sep 24, 2018

2 of 3 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
code-review/reviewable 1 file reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless changed the title from Adding "¤" and "|" to isName() to Fix the possibility to create a customer with "¤" or " Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment