Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific price created for a cart is displayed in the front end as the product price #8762

Merged
merged 2 commits into from Apr 13, 2018

Conversation

@roja45
Copy link
Contributor

commented Feb 14, 2018

Questions Answers
Branch? 1.7.3.x
Description? I fixed this same bug in Prestashop 1.6, but it seems you've migrated the specific price code to 1.7 prior to my fix being applied it doesn't include an id_cart value 0 in the where cluase and returns any cart specific prices
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4832
How to test? Create a specificprice for a cart, after applying this fix the specificprice won't be shown on the front end for all users

This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented Feb 14, 2018

Hello roja45!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@roja45

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2018

Not sure why it's picked up the previous change from 2016, it's almost the same fix, but the second part of the fix required for 1.6 is actually correct in 1.7, it's just missing the first part of the fix.

@LittleBigDev

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@LittleBigDev
Copy link
Contributor

left a comment

Thank you @roja45

@eternoendless eternoendless changed the title BOOM-4832: Specific price created for a cart is displayed in the front end as the product price Specific price created for a cart is displayed in the front end as the product price Feb 27, 2018

@eternoendless eternoendless force-pushed the roja45:develop branch from a873d5b to c4b3e81 Mar 26, 2018

@eternoendless eternoendless changed the base branch from develop to 1.7.3.x Mar 26, 2018

@eternoendless eternoendless added this to the 1.7.3.2 milestone Mar 26, 2018

@LittleBigDev

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2018

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.


Comments from Reviewable

@LittleBigDev
Copy link
Contributor

left a comment

good to me

@LittleBigDev

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2018

QA needs to approve again after these new commits

@marionf

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2018

Hello @roja45
Before when I added an id_cart in the specific_price table, it was applied for this cart but also for other carts.
When I test your PR, I add an id_cart in the specific_price table, but in FO I don't see the specific price in this cart.

@roja45

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2018

Is that a question to me? If you set the cart id with the fix in place the specific price will only be applied to that cart, I'm confident that is the case as I use this fix daily in my modules. There are lots of settings on a specific price for it not to be applied though.

@marionf

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2018

@roja45

I am sorry but it doesn't work for me, the specific price isn't displayed in the cart.
Please see screenshots below:

capture du 2018-03-30 11-39-26

capture du 2018-03-30 11-41-07

capture du 2018-03-30 11-43-30

capture du 2018-03-30 11-57-11

@roja45

This comment has been minimized.

Copy link
Contributor Author

commented Mar 30, 2018

@marionf How did you create the specific price, via the back office? I'm not sure it makes any sense to create cart specific prices via the back office, or even that you can, as how would you know the cart id. I use this process to create cart specific prices during checkout when you can be sure you are applying the price to the cart you want it to be applied to.

@eternoendless

This comment has been minimized.

Copy link
Member

commented Apr 13, 2018

Thank you @roja45

@eternoendless eternoendless merged commit 713ae76 into PrestaShop:1.7.3.x Apr 13, 2018

2 of 3 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
code-review/reviewable 1 file reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.