Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show unit price within a tax in order confirmation e-mail #8766

Merged
merged 1 commit into from Mar 26, 2018

Conversation

@kpodemski
Copy link
Contributor

commented Feb 16, 2018

Questions Answers
Branch? develop
Description? we need unit price to be displayed within a tax when it's needed, this is fix for that
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? for sure (BOOM-4889)
How to test? make an order, check unit price for a product without a combination, it's tax exluced even tho you'll have tax enabled

please cherry pick this to 1.7.3


This change is Reviewable

@LittleBigDev LittleBigDev added the 1.7.x label Feb 22, 2018

@LittleBigDev

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@LittleBigDev
Copy link
Contributor

left a comment

Thank you @kpodemski

@marionf marionf added QA ✔️ and removed waiting for QA labels Feb 23, 2018

@Quetzacoalt91 Quetzacoalt91 changed the base branch from develop to 1.7.3.x Feb 23, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Feb 23, 2018

Changed base branch from author request. Will be available on develop in a second time.

@eternoendless eternoendless added this to the 1.7.3.1 milestone Mar 26, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

commented Mar 26, 2018

Thank you @kpodemski

@eternoendless eternoendless merged commit 2f10ee7 into PrestaShop:1.7.3.x Mar 26, 2018

2 of 3 checks passed

code-review/reviewable 1 file left (LittleBigDev)
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.