Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace serialize with json_encode #8772

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

tomlev
Copy link
Contributor

@tomlev tomlev commented Feb 19, 2018

Questions Answers
Branch? 1.7.2.x
Description? Use json_encode() instead of serialize(). Many thanks to ROBIN PERAGLIE from RIPS TECHNOLOGIES
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4804
How to test? test if there is no regression: change of delivery option on cart / filter (especialy date one) still works on AdminOrders

Important guidelines


This change is Reviewable

@PrestaShop PrestaShop deleted a comment from prestonBot Feb 19, 2018
@eternoendless eternoendless added the Waiting for QA Status: action required, waiting for test feedback label Feb 19, 2018
@eternoendless eternoendless added this to the 1.7.2.5 milestone Feb 19, 2018
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Feb 20, 2018
@eternoendless
Copy link
Member

Thank you @tomlev

@eternoendless eternoendless merged commit 6efca41 into PrestaShop:1.7.2.x Feb 20, 2018
@eternoendless eternoendless changed the title replace serialize with json_encode Replace serialize with json_encode Feb 20, 2018
@kpodemski
Copy link
Contributor

Hey @eternoendless

what's the deal with this change? security? some issues with newest browsers? why is this part of 1.7.2.x?

@eternoendless
Copy link
Member

@ecomm360
Copy link
Contributor

Hello @eternoendless,
this change introduces directly the use of json_encode and json_decode PHP funcions. Will be better to use Tools::jsonDecode Tools::jsonEncode, right?

To respect the use of Tools class.

Thanks!

@Matt75
Copy link
Contributor

Matt75 commented Feb 22, 2018

@ecomm360 Tools::jsonDecode and Tools::jsonEncode are deprecated since 1.7.0 ;)

MathiasReker added a commit to MathiasReker/prestashop that referenced this pull request Jul 9, 2018
Use json_encode() instead of serialize(). See why here: PrestaShop/PrestaShop#8772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA ✔️ Status: check done, code approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants