Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little css override for modal title #8779

Merged
merged 2 commits into from Mar 26, 2018

Conversation

@sLorenzini
Copy link
Contributor

commented Feb 20, 2018

Questions Answers
Branch? 1.7.3.x
Description? Little css override for modal title in translation pages (header text was to the right and move to the left)
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4739
How to test? Go to translation page for template, change a translation field without saving and click on another page. Modal appears with confirmation.

Important guidelines


This change is Reviewable

@sLorenzini sLorenzini changed the title Boom 4739 Little css override for modal title Feb 20, 2018

@alegout

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2018

:lgtm:


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@alegout
Copy link
Contributor

left a comment

Thank you!

@eternoendless eternoendless added this to the 1.7.3.1 milestone Mar 23, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

commented Mar 26, 2018

Thank you @sLorenzini

@eternoendless eternoendless merged commit 31a0421 into PrestaShop:1.7.3.x Mar 26, 2018

2 of 3 checks passed

code-review/reviewable 4 files left (alegout)
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.