Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the product discount in the Front Office #8813

Merged
merged 4 commits into from Mar 30, 2018

Conversation

@hadrich-hatem
Copy link
Contributor

commented Feb 28, 2018

Questions Answers
Branch? 1.7.3.x
Description? Check the product discount in the FO when price display method is tax included or excluded. Create, edit, delete, delete with bulk action and check tax rule in the BO
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3580
How to test? See below

To test, you must run these commands:

  1. path=full/11_international/3_taxes/1_create_edit_delete_tax_rule_in_BO.js npm run specific-test -- --URL=BackOfficeURL
  2. Run the script path=full/14_discount/5_check_discount_table_in_FO.js npm run specific-test -- --URL=FrontOfficeURL

This change is Reviewable

@hadrich-hatem hadrich-hatem force-pushed the hadrich-hatem:script_boom_3580 branch from 1d7727b to 14818d9 Feb 28, 2018

@fatmaBouchekoua fatmaBouchekoua added the TE label Mar 6, 2018

@mickaelandrieu mickaelandrieu added the 1.7.x label Mar 8, 2018

@hadrich-hatem hadrich-hatem force-pushed the hadrich-hatem:script_boom_3580 branch from dc99f5c to c0e907d Mar 12, 2018

@fatmaBouchekoua fatmaBouchekoua added the WIP label Mar 12, 2018

@hadrich-hatem hadrich-hatem force-pushed the hadrich-hatem:script_boom_3580 branch from c0e907d to 5607c5e Mar 14, 2018

@fatmaBouchekoua fatmaBouchekoua removed the WIP label Mar 14, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Mar 28, 2018

It seems we need a rebase here.

@hadrich-hatem hadrich-hatem force-pushed the hadrich-hatem:script_boom_3580 branch 2 times, most recently from bb5de52 to e05b0f0 Mar 29, 2018

@hadrich-hatem hadrich-hatem force-pushed the hadrich-hatem:script_boom_3580 branch from e05b0f0 to d71a97f Mar 29, 2018

@hadrich-hatem

This comment has been minimized.

Copy link
Contributor Author

commented Mar 30, 2018

Hello @Quetzacoalt91,
The rebase of this PR done.
Best regard,

@Quetzacoalt91 Quetzacoalt91 merged commit 15f8b6e into PrestaShop:1.7.3.x Mar 30, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.3.1 milestone Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.