New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX PHP 7.1 compat in WebserviceOutputBuilder #8821

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
4 participants
@axometeam
Contributor

axometeam commented Mar 6, 2018

Questions Answers
Branch? 1.6.1.x
Description? PHP 7.1 does not auto convert string to array and throws a Fatal error: http://php.net/manual/fr/migration71.incompatible.php#migration71.incompatible.empty-string-index-operator
Type? bug fix
Category? WS
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Use WS to display schema or synopsys of objects: /api/products?schema=blank or /api/products?schema=synopsis

This change is Reviewable

@axometeam

This comment has been minimized.

Contributor

axometeam commented Mar 6, 2018

BTW, this was fixed in 1.7 in June 2017: 102d6fd#diff-33988359800b2bdab1bd4797177a9b10

@Quetzacoalt91 Quetzacoalt91 added this to the 1.6.1.19 milestone Mar 8, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Mar 8, 2018

Thanks for your contribution @axometeam, this will be part of the next(s) release(s).

@mickaelandrieu mickaelandrieu added the Bug label Apr 3, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.19, 1.6.1.20 May 24, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 1b0404c into PrestaShop:1.6.1.x Jun 15, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Jun 15, 2018

Thank you @axometeam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment