New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check add to cart button inability when the quantities of the product in the cart is not available #8824

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
8 participants
@fouratachour
Contributor

fouratachour commented Mar 6, 2018

Questions Answers
Branch? develop
Description? add to cart button is enabled even when the quantities of the product in the cart is not available
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-2805
How to test? See below

TEST_PATH=full/01_orders/4_check_adding_product_to_cart_with_unavailable_quantities.js npm run specific-test -- --URL=BackOfficeURL


This change is Reviewable

@fouratachour fouratachour changed the title from Boom 2805 to check add to cart button inability when the quantities of the product in the cart is not available Mar 6, 2018

@fatmaBouchekoua fatmaBouchekoua added the TE label Mar 6, 2018

@mickaelandrieu mickaelandrieu added the 1.7.x label Mar 8, 2018

@mickaelandrieu mickaelandrieu requested a review from fatmaBouchekoua Mar 8, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.3.1 milestone Mar 8, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Mar 20, 2018

Member

A rebase is required here to make the tests pass. :)

Member

Quetzacoalt91 commented Mar 20, 2018

A rebase is required here to make the tests pass. :)

@mbadrani

This comment has been minimized.

Show comment
Hide comment
@mbadrani

mbadrani Apr 13, 2018

Contributor

could you rebase it on to develop branch?

Contributor

mbadrani commented Apr 13, 2018

could you rebase it on to develop branch?

@fouratachour fouratachour changed the base branch from 1.7.3.x to develop Apr 13, 2018

@fouratachour fouratachour changed the base branch from develop to 1.7.3.x Apr 13, 2018

@fouratachour fouratachour changed the base branch from 1.7.3.x to develop Apr 13, 2018

@fouratachour

This comment has been minimized.

Show comment
Hide comment
@fouratachour

fouratachour Apr 13, 2018

Contributor

Hello @mbadrani
Done .

Contributor

fouratachour commented Apr 13, 2018

Hello @mbadrani
Done .

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Sep 12, 2018

@mbadrani mbadrani merged commit 7ab4071 into PrestaShop:develop Sep 12, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jolelievre jolelievre changed the title from check add to cart button inability when the quantities of the product in the cart is not available to Check add to cart button inability when the quantities of the product in the cart is not available Oct 19, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment