New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check displaying the cover image if no image is selected for declination #8825

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
8 participants
@fouratachour
Contributor

fouratachour commented Mar 6, 2018

Questions Answers
Branch? develop
Description? Check displaying the cover image if no image is selected for declination
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3098
How to test? TEST_PATH=full/02_product/11_check_cover_picture_in_product_with_combinations.js npm run specific-test -- --URL=BackOfficeURL

This change is Reviewable

@fatmaBouchekoua fatmaBouchekoua added the TE label Mar 6, 2018

@mickaelandrieu mickaelandrieu requested a review from fatmaBouchekoua Mar 8, 2018

@mickaelandrieu mickaelandrieu added the 1.7.x label Mar 8, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.3.1 milestone Mar 8, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Mar 20, 2018

Member

A rebase is required here as well. :)

Member

Quetzacoalt91 commented Mar 20, 2018

A rebase is required here as well. :)

@mbadrani

This comment has been minimized.

Show comment
Hide comment
@mbadrani

mbadrani Apr 13, 2018

Contributor

could you rebase it on to develop branch

Contributor

mbadrani commented Apr 13, 2018

could you rebase it on to develop branch

@fouratachour fouratachour changed the base branch from 1.7.3.x to develop Apr 13, 2018

@Quetzacoalt91 Quetzacoalt91 removed this from the 1.7.3.2 milestone Apr 23, 2018

@mickaelandrieu mickaelandrieu added develop and removed 1.7.x labels May 7, 2018

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Sep 12, 2018

@mbadrani mbadrani merged commit e44fa3b into PrestaShop:develop Sep 12, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment