New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending a copy of the contact message to the "author" (avoid spam) #8828

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
4 participants
@eternoendless
Member

eternoendless commented Mar 7, 2018

Questions Answers
Branch? 1.6.1.x
Description? The contact form is being exploited by spammers. This PR stops the "author" from receiving a copy of the message, which mitigates the problem.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? (partially) http://forge.prestashop.com/browse/BOOM-4288
How to test? Use the contact form, you shouldn't receive a copy of the message anymore

Kudos to @rGaillard for the patch!


This change is Reviewable

@eternoendless eternoendless added this to the 1.6.1.19 milestone Mar 7, 2018

@PrestaEdit

This comment has been minimized.

Show comment
Hide comment
@PrestaEdit

PrestaEdit Mar 8, 2018

Contributor

Better will be to allow the sender of the message to ask if he want a copy, with a checkbox, maybe ?

Contributor

PrestaEdit commented Mar 8, 2018

Better will be to allow the sender of the message to ask if he want a copy, with a checkbox, maybe ?

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Mar 8, 2018

Member

The sender would always choose yes if he wants to spam people

Member

eternoendless commented Mar 8, 2018

The sender would always choose yes if he wants to spam people

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Mar 8, 2018

Contributor

@eternoendless

I have an error when I try to send a message

capture du 2018-03-08 10-10-47

My emails parameters are configured and I received the test email with success

Contributor

marionf commented Mar 8, 2018

@eternoendless

I have an error when I try to send a message

capture du 2018-03-08 10-10-47

My emails parameters are configured and I received the test email with success

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Mar 15, 2018

Member

But... it works on my machine! 😁

Member

eternoendless commented Mar 15, 2018

But... it works on my machine! 😁

@eternoendless eternoendless modified the milestones: 1.6.1.19, 1.6.1.20 May 24, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.20, 1.6.1.21 Jun 27, 2018

@eternoendless eternoendless modified the milestones: 1.6.1.21, 1.6.1.22 Sep 24, 2018

@eternoendless eternoendless merged commit 1f8b5d3 into PrestaShop:1.6.1.x Sep 24, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:stop-spam branch Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment