Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tinymce RTL text direction #8838

Merged
merged 1 commit into from May 7, 2018
Merged

Fix tinymce RTL text direction #8838

merged 1 commit into from May 7, 2018

Conversation

Danoosh
Copy link
Member

@Danoosh Danoosh commented Mar 11, 2018 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Fix text direction bug in tinymce editor for RTL languages
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Editor text direction is LTR now. You can see admin product add/edit page in both RTL and LTR languages.

Important guidelines

This change is Reviewable

@Danoosh Danoosh force-pushed the rtl-mce branch 3 times, most recently from e9312a5 to b1f7f21 Compare March 11, 2018 03:21
@mickaelandrieu mickaelandrieu added Bug Type: Bug 1.7.x Branch labels Apr 3, 2018
@LittleBigDev
Copy link
Contributor

:lgtm:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

LittleBigDev
LittleBigDev approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@LittleBigDev LittleBigDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Danoosh

@LittleBigDev LittleBigDev added the Waiting for QA Status: action required, waiting for test feedback label Apr 25, 2018
@marionf marionf added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 2, 2018
@marionf
Copy link
Contributor

marionf commented May 2, 2018

@eternoendless 1.7.4.0 ?

@eternoendless eternoendless added this to the 1.7.4.0 milestone May 7, 2018
@eternoendless
Copy link
Member

Thank you @Danoosh

@eternoendless eternoendless merged commit 9459ea2 into PrestaShop:develop May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleBigDev LittleBigDev LittleBigDev approved these changes

Assignees
No one assigned
Labels
1.7.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Danoosh @LittleBigDev @marionf @eternoendless @mickaelandrieu