Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu width and submenu hover on header #8846

Merged
merged 2 commits into from Mar 16, 2018

Conversation

@sLorenzini
Copy link
Contributor

commented Mar 13, 2018

Questions Answers
Branch? 1.7.3.x
Description? Menu was not filled all the width of the header when search bar was removed. Submenu was fixed to allow better display
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4307
How to test? Add some links menu to make 2 rows.

This change is Reviewable

@LittleBigDev

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2018

:lgtm:


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@LittleBigDev
Copy link
Contributor

left a comment

Thank you @sLorenzini

@LittleBigDev LittleBigDev added this to the 1.7.3.1 milestone Mar 14, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Mar 14, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

commented Mar 16, 2018

Thank you @sLorenzini

@eternoendless eternoendless merged commit 23f44ad into PrestaShop:1.7.3.x Mar 16, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
code-review/reviewable 6 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.