Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override advertising module on classic template to fix image width #8847

Merged
merged 3 commits into from Mar 19, 2018

Conversation

@sLorenzini
Copy link
Contributor

commented Mar 13, 2018

Questions Answers
Branch? 1.7.3.x
Description? Add override advertising module on classic template to fix width image in the column
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4068
How to test? Configure advertising module by adding an ad.

This change is Reviewable

@LittleBigDev

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2018

:lgtm:


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


themes/classic/modules/ps_advertising/index.php, line 26 at r1 (raw file):

*  International Registered Trademark & Property of PrestaShop SA
*/
                        

Care about trailing whitespaces. Your IDE can be configured to trim them.


themes/classic/modules/ps_advertising/ps_advertising.tpl, line 27 at r1 (raw file):

<div class="advertising-block">
	<a href="{$adv_link}" title="{$adv_title}"><img src="{$image}" alt="{$adv_title}" title="{$adv_title}"/></a>

Care about indenting. Use only spaces (not tabulations)


Comments from Reviewable

@LittleBigDev
Copy link
Contributor

left a comment

Thank you @sLorenzini

@LittleBigDev LittleBigDev added this to the 1.7.3.1 milestone Mar 14, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Mar 14, 2018

@eternoendless eternoendless changed the title Override advertising module on classic template to fix width image Override advertising module on classic template to fix image witdth Mar 19, 2018

@eternoendless eternoendless changed the title Override advertising module on classic template to fix image witdth Override advertising module on classic template to fix image width Mar 19, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

commented Mar 19, 2018

Thank you @sLorenzini

@eternoendless eternoendless merged commit 6f9f787 into PrestaShop:1.7.3.x Mar 19, 2018

2 of 3 checks passed

code-review/reviewable 3 files, 2 discussions left (LittleBigDev, sLorenzini)
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.