Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User club and UserVoice on BO link footer #8849

Merged
merged 1 commit into from Mar 26, 2018

Conversation

@sLorenzini
Copy link
Contributor

commented Mar 13, 2018

Questions Answers
Branch? 1.7.3.x
Description? Add User club and UserVoice on BO link footer.
Type? new feature
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/FF-166
How to test? Scroll to bottom page on Dashboard BO and see new links

This change is Reviewable

@LittleBigDev

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2018

:lgtm:

Straightforward.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@LittleBigDev
Copy link
Contributor

left a comment

Thank you @sLorenzini

/ 
<a href="http://feedback.prestashop.com/forums/387864-prestashop-1-7-x?utm_source=back-office&amp;utm_medium=footer&amp;utm_campaign=back-office-{$lang_iso|upper}&amp;utm_content={if $host_mode}cloud{else}download{/if}" class="footer_link _blank">
<i class="icon-lightbulb"></i>
{l s='Feature Requests' d='Admin.Navigation.Footer'}

This comment has been minimized.

Copy link
@eternoendless

eternoendless Mar 14, 2018

Member

@sLorenzini @colinegin @Saycile I don't think these wordings exist in the 1.7.3 catalog.

We cannot add new ones until the next minor, so we have to either work around that (as in, hardcode it in English) or wait until 1.7.4.

@LittleBigDev

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2018

@emmanuelf75009

This comment has been minimized.

Copy link

commented Mar 23, 2018

Hi, as said with @eternoendless, this field will be named "Feature Requests" as it is an international standard name in 1.7.3.x and will be translatable from 1.7.4

@eternoendless eternoendless added this to the 1.7.3.1 milestone Mar 23, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Mar 26, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

commented Mar 26, 2018

Thank you @sLorenzini

@eternoendless eternoendless merged commit 0ae81f0 into PrestaShop:1.7.3.x Mar 26, 2018

2 of 3 checks passed

code-review/reviewable 1 discussion left (eternoendless, sLorenzini)
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.