Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check generated combinations table #8898

Merged
merged 1 commit into from Apr 3, 2018

Conversation

@fouratachour
Copy link
Contributor

commented Mar 29, 2018

Questions Answers
Branch? 1.7.3.x
Description? Check that the combinations table is well generated
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4202
How to test? path=high/02_product/3_create_product_with_combination.js npm run specific-test -- --URL=BackOfficeURL

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Mar 29, 2018

Should we merge this one too @Quetzacoalt91 ?

@fatmaBouchekoua fatmaBouchekoua added the TE label Mar 30, 2018

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented Apr 3, 2018

Hello @Quetzacoalt91, I'll merge this one too (no conflicts).

Thanks @fouratachour

@mickaelandrieu mickaelandrieu merged commit 326bd5e into PrestaShop:1.7.3.x Apr 3, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.3.1 milestone Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.