New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect all hooks for the debugger #8910

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
2 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Apr 2, 2018

Questions Answers
Branch? develop
Description? Hooks dispatched using HookDispatcher service are not collected by the debugger because the class LegacyHookSubscriber doesn't call them. Now they are dispatched, you can see the difference on Administration, Maintenance or Performance page when looking at "not called hooks" in Hooks section of the debugger toolbar.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Re-install your shop if you didn't do it since the addition of these hooks. Now they are dispatched, you should see one more Hook dispatched in "not called hooks" section of Hooks section of the debugger toolbar for Administration, Maintenance or Performance pages.

Important guidelines


This change is Reviewable

@mickaelandrieu mickaelandrieu requested review from Quetzacoalt91 and alegout Apr 2, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Apr 3, 2018

Fine for me, thank you @mickaelandrieu

@Quetzacoalt91 Quetzacoalt91 merged commit cdfd44c into PrestaShop:develop Apr 3, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.4.0 milestone Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment