Fix issue with pack in fixtures (installer) #8913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -560,6 +560,20 @@ public function createEntityConfiguration($identifier, array $data, array $data_ | |||
| $this->storeId($entity, $identifier, $entity_id); | |||
| } | |||
|
|
|||
| /** | |||
| * @inheritdoc | |||
There was a problem hiding this comment.
{@inheritdoc} but if you sue this annotation you don't have to use @param and @return annotations: are you sure this is required here?
mickaelandrieu
previously approved these changes
Apr 3, 2018
mickaelandrieu
added
the
Waiting for QA
|
@alegout |
marionf
added
Waiting for author
marionf
added
QA ✔️
Fix issue with pack in fixtures Fix phpdoc Add pack.xml for fixtures
mickaelandrieu
approved these changes
Apr 4, 2018
|
Thank you @alegout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important guidelines
This change is