Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CDN management in Performance page #8921

Merged

Conversation

@mickaelandrieu
Copy link
Member

commented Apr 5, 2018

Questions Answers
Branch? develop
Description? A CDN can be an invalid URL and Front Office can't manage CDN with port included.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4978
How to test? Enter a valid CDN like cdn77.com and it should pass and a not valid CDN like https://cdn77.com and it should fail. Note that "basically", https://cdn77.com is a valid CDN too, but Front Office is unable to deal with CDN registered as urls...

Important guidelines


This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2018

Code approved and QA approved => LGTM /c @eternoendless

@mickaelandrieu mickaelandrieu merged commit 28edfb6 into PrestaShop:1.7.3.x Apr 5, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:BOOM-4978-cdn-management branch Apr 5, 2018

@eternoendless eternoendless added this to the 1.7.3.1 milestone Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.