Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop generating RTL css file for the default theme using SASS #8925

Merged

Conversation

@eternoendless
Copy link
Member

commented Apr 6, 2018

Questions Answers
Branch? 1.7.3.x
Description? The RTL CSS file of the default theme should be generated automatically upon install of an RTL language, based on the LTR version. If the file already exists, it isn't generated properly. This PR removes the old SASS file that was used to generate it before the new system, and stops tracking the CSS file.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5264
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

Remove RTL version of the default theme.
It should be generated automatically upon install of an RTL language, based on the LTR version. If the file already exists, it isn't generated.

@eternoendless eternoendless added this to the 1.7.3.1 milestone Apr 6, 2018

@marionf marionf added the QA ✔️ label Apr 6, 2018

@alegout
alegout approved these changes Apr 6, 2018
Copy link
Contributor

left a comment

Thank you @eternoendless

@Quetzacoalt91 Quetzacoalt91 merged commit 3aec669 into PrestaShop:1.7.3.x Apr 6, 2018

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:fix-rtl-default-theme branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.