New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on read more #8941

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
8 participants
@hadrich-hatem
Contributor

hadrich-hatem commented Apr 12, 2018

Questions Answers
Branch? develop
Description? This PR allows to : Check the click on "Read more" button, Check that the modal is well opened, Check that the content of all tabs is not empty, Install MBO module if it's not installed, Uninstall MBO module if it's installed.
Type? new feature
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4951
How to test? Run the script TEST_PATH=full/10_module/8_read_more_module.js npm run specific-test -- --URL=FrontOfficeURL --MODULE=mailchimpintegration

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Apr 23, 2018

Contributor

Hello @hadrich-hatem, would you mind to rebase your pull request?

Thank you

Contributor

mickaelandrieu commented Apr 23, 2018

Hello @hadrich-hatem, would you mind to rebase your pull request?

Thank you

@mickaelandrieu mickaelandrieu added develop and removed 1.7.x labels May 7, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Jun 22, 2018

Contributor

@hadrich-hatem
We need to check each tab of the modal after clicking on "read more" link: Overview, additional information, benefits, features

Contributor

marionf commented Jun 22, 2018

@hadrich-hatem
We need to check each tab of the modal after clicking on "read more" link: Overview, additional information, benefits, features

@hadrich-hatem

This comment has been minimized.

Show comment
Hide comment
@hadrich-hatem

hadrich-hatem Jun 22, 2018

Contributor

@marionf,
Alright, i will add the missing check ASAP.
Thank you,

Contributor

hadrich-hatem commented Jun 22, 2018

@marionf,
Alright, i will add the missing check ASAP.
Thank you,

@hadrich-hatem

This comment has been minimized.

Show comment
Hide comment
@hadrich-hatem

hadrich-hatem Jun 26, 2018

Contributor

Hello,
I'm waiting for the merge of this PR 9215 to be able to continue the dev of the script.
Best regards,

Contributor

hadrich-hatem commented Jun 26, 2018

Hello,
I'm waiting for the merge of this PR 9215 to be able to continue the dev of the script.
Best regards,

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Sep 13, 2018

Contributor

@mbadrani this PR is ready to be merged

Contributor

fatmaBouchekoua commented Sep 13, 2018

@mbadrani this PR is ready to be merged

@mbadrani mbadrani merged commit 107d5e3 into PrestaShop:develop Sep 13, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment