New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks for recommended modules & themes #8947

Merged
merged 4 commits into from Apr 26, 2018

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Apr 13, 2018

Questions Answers
Branch? develop
Description? Brings new hook to the back office. One for the top nav bar on legacy pages, one for the end of content on all BO page.
Type? improvement
Category? BO
BC breaks? Nope
Deprecations? Yes
Fixed ticket? http://forge.prestashop.com/browse/FF-167
How to test? Some content has been removed: Recommended modules on payment & carrier pages, "Live from the marketplace" on the theme page.

New hooks

  • displayDashboardToolbarTopMenu: Already exists on new pages, backported on legacy controllers
  • displayAdminEndContent: Display HTML at the end of the content part (= before the footer) on new & legacy pages

This change is Reviewable

@@ -24,4 +24,5 @@ INSERT IGNORE INTO `PREFIX_hook` (`id_hook`, `name`, `title`, `description`, `po
(NULL, 'displayPerformancePageForm', 'Manage Performance Page form fields', 'This hook adds, update or remove fields of the Performance Page form', '1'),
(NULL, 'actionPerformancePageFormSave', 'Processing Performance page form', 'This hook is called when the Performance Page form is processed', '1'),
(NULL, 'displayMaintenancePageForm', 'Manage Maintenance Page form fields', 'This hook adds, update or remove fields of the Maintenance Page form', '1'),
(NULL, 'actionMaintenancePageFormSave', 'Processing Maintenance page form', 'This hook is called when the Maintenance Page form is processed', '1');
(NULL, 'actionMaintenancePageFormSave', 'Processing Maintenance page form', 'This hook is called when the Maintenance Page form is processed', '1'),

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Apr 15, 2018

Contributor

thanks for that :) it will be available in hook debugger 👍

@@ -79,6 +79,7 @@
<div>{l s='Menu' d='Admin.Navigation.Menu'}</div>
</a>
<ul id="toolbar-nav" class="nav nav-pills pull-right collapse navbar-collapse">
{hook h='displayDashboardToolbarTopMenu'}

This comment has been minimized.

@mickaelandrieu

@mickaelandrieu mickaelandrieu added develop and removed 1.7.x labels Apr 23, 2018

@prasanthSelvar

This comment has been minimized.

prasanthSelvar commented Apr 25, 2018

There is just a display issue in Theme & Logo page.
With this PR:
capture 2018-04-03 at 10 45 03

In 1.7.3.1:
capture 2018-04-03 at 10 49 08

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Apr 25, 2018

Thank you @prasanthSelvar, there were two lines of code asking for this form to be moved.

I brought back them.

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Apr 25, 2018

@Quetzacoalt91 rebase needed here :)

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Apr 26, 2018

Thanks everyone!

@mickaelandrieu mickaelandrieu merged commit a51c40e into PrestaShop:develop Apr 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment