New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customization ID to cart ajax response and updateCart event data #8956

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
5 participants
@unlocomqx
Contributor

unlocomqx commented Apr 18, 2018

Questions Answers
Branch? develop
Description? This adds the customization ID to be used by the ps_shopping_cart module. It will allow to improve this PR PrestaShop/ps_shoppingcart#20 so instead of reading the customization ID from the DOM, it will be able to read it from the event data. Line: PrestaShop/ps_shoppingcart@58cf948#diff-e9db747301f30dfe08b54bf4e7cfe35bR41
Type? improvement
Category? CO
BC breaks? no
Deprecations? no

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Apr 23, 2018

Hmm I don't know, what do you think @Quetzacoalt91?

Sounds like a good idea, if $this->customization_id is always available.

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Apr 23, 2018

Indeed, sounds good to me

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented May 25, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented May 25, 2018

Yes, to be tested with the module PR :)

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 5, 2018

Thanks @unlocomqx !

@mickaelandrieu mickaelandrieu merged commit 78ce34d into PrestaShop:develop Jun 5, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment