New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML formated configuration not saved #8993

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
6 participants
@shaffe-fr
Copy link
Contributor

shaffe-fr commented Apr 26, 2018

Questions Answers
Branch? develop
Description? HTML configuration is not authorized and thus not saved if the last field to be saved doesn't have any validation. This was caused by an unnecessary isset.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? In a back-office controller create a configuration form with two fields. A textareaLang with a isCleanHtml validation and the autoload_rte flag and a second field of any type but with no validation set. Type some riche text in the first field and save. The HTML will be saved properly.

This change is Reviewable

@prestonBot prestonBot added the develop label Apr 27, 2018

@mickaelandrieu mickaelandrieu added the Bug label Apr 27, 2018

@shaffe-fr shaffe-fr dismissed stale reviews from eternoendless and mickaelandrieu via 708a5f9 Jan 22, 2019

@shaffe-fr shaffe-fr force-pushed the shaffe-fr:patch-1 branch from c59c905 to 708a5f9 Jan 22, 2019

@shaffe-fr

This comment has been minimized.

Copy link
Contributor Author

shaffe-fr commented Jan 22, 2019

I updated the commit to fix possible merge conflicts.

@ntiepresta ntiepresta self-assigned this Jan 25, 2019

@ntiepresta

This comment has been minimized.

Copy link

ntiepresta commented Jan 25, 2019

@shaffe-fr
Hello, may I have the details please how can we reproduce the issue fixed this Pr?
thanks

@shaffe-fr

This comment has been minimized.

Copy link
Contributor Author

shaffe-fr commented Jan 25, 2019

Here is the textual description, I'll try to make a snippet.
In any back-office controller create a configuration form with two fields. A textareaLang with a isCleanHtml validation and the autoload_rte flag and a second field of any type but with no validation set. Type some riche text in the first field and save. The HTML will not be saved properly without the fix.

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Jan 29, 2019

@mickaelandrieu mickaelandrieu merged commit afb4c9f into PrestaShop:develop Jan 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Jan 29, 2019

It's on me @ntiepresta 👍

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment