New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Rewrite base on Api rule #9034

Merged
merged 7 commits into from Nov 29, 2018

Conversation

Projects
None yet
6 participants
@123monsite-regis
Copy link
Contributor

123monsite-regis commented May 7, 2018

Questions Answers
Branch? develop
Description? missing Rewrite base on Api rule : on server configuration whith customs rewrite base, [shop Url]/api does not target correctly [shop Url]/api/ as the rule should do.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? enable rewriting and web service, then go on [shop Url]/api

This change is Reviewable

123monsite-regis and others added some commits Jan 16, 2018

@prestonBot prestonBot added the develop label May 7, 2018

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented May 7, 2018

Maybe we can change both lines by:

RewriteRule ^api(?:/(.*))?$ %{ENV:REWRITEBASE}webservice/dispatcher.php?url=$1 [QSA,L]
@123monsite-regis

This comment has been minimized.

Copy link
Contributor

123monsite-regis commented May 7, 2018

@PierreRambaud , i modified my commit whith your proposition.
thanks

@mickaelandrieu mickaelandrieu changed the title CO: missing Rewrite base on Api rule Added missing Rewrite base on Api rule May 7, 2018

@mickaelandrieu mickaelandrieu added the Bug label May 7, 2018

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 23, 2018

Really sorry for the delay :/ Can you rebase your branch?

@123monsite-regis

This comment has been minimized.

Copy link
Contributor

123monsite-regis commented Nov 28, 2018

mm, i tried to rebase,
sorry i'm not a really good expert on rebasing a quick patch done with github interface.
if rebase is not ok, tell me and i will close this pull and open an other.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 28, 2018

It looks ok for Github, so it's ok for us :D

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 28, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 546d251 into PrestaShop:develop Nov 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Nov 29, 2018

Thank you @123monsite-regis

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment