New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FO : Fix override of ProductController #9041

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
5 participants
@nenes25
Copy link
Contributor

nenes25 commented May 9, 2018

Questions Answers
Branch? develop.
Description? Fix an error linked to private attributes and method when we want to override the class controllers/front/ProductController.php
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Create an override of the class ProductController in override/controller/front/ProductController.php , no more errors should be raised.

This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented May 9, 2018

Hello @nenes25!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@nenes25 nenes25 referenced this pull request May 9, 2018

Merged

Fix controller override #9042

@nenes25

This comment has been minimized.

Copy link
Contributor

nenes25 commented May 9, 2018

In addition i've make an other pull request which will fix all the others impacted controllers
See #9042

@marionf marionf self-assigned this Nov 27, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Nov 27, 2018

@marionf marionf removed their assignment Nov 27, 2018

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Nov 27, 2018

Hey @nenes25 can you rebase your Pull requests and we will merge your changes :)

@Quetzacoalt91 Quetzacoalt91 force-pushed the nenes25:fix-productcontroller branch from e107c94 to 1f38198 Nov 29, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Nov 29, 2018

I resolved the conflicts on your PR @nenes25. Note the method you tried to update the visibility on has disappeared.

@Quetzacoalt91 Quetzacoalt91 merged commit d696e0c into PrestaShop:develop Nov 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Nov 29, 2018

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Nov 29, 2018

Thank you @nenes25

@nenes25

This comment has been minimized.

Copy link
Contributor

nenes25 commented Nov 29, 2018

Thanks for resolving the conflict ;), sorry i was not reactive enough to do it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment