New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error populating tables when installing in Greek #9052

Merged
merged 1 commit into from May 14, 2018

Conversation

Projects
None yet
5 participants
@PierreRambaud
Contributor

PierreRambaud commented May 11, 2018

Questions Answers
Branch? 1.7.4.x
Description? Error populating tables during installation.
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-4340
How to test? Install in greek, should be block at 36% or 39%.

This change is Reviewable

Malformed xml
Error populating tables during install in greek

@prestonBot prestonBot added the 1.7.4.x label May 11, 2018

@eternoendless

Nice one!

@eternoendless eternoendless added this to the 1.7.4.0 milestone May 11, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels May 11, 2018

@mickaelandrieu mickaelandrieu added the Bug label May 11, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented May 11, 2018

Hello, how about introducing an XML linter to avoid any regression? Something like xml-linter =>> https://github.com/mickaelandrieu/xml-linter

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented May 11, 2018

@mickaelandrieu very good idea 👍

@eternoendless eternoendless changed the title from Error populating tables to Fix error populating tables when installing in Greek May 14, 2018

@eternoendless

This comment has been minimized.

Member

eternoendless commented May 14, 2018

Thank you @PierreRambaud

@eternoendless eternoendless merged commit f7ffb2d into PrestaShop:1.7.4.x May 14, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/boom-4340 branch May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment