Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gift wrapping fees #9069

Merged
merged 2 commits into from May 15, 2018

Conversation

@tomlev
Copy link
Member

commented May 14, 2018

Questions Answers
Branch? develop
Description? fix gift wrapping fees added even if not checked
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5328
How to test? Activate gift wrapping fees on BO. Check fees are not added on cart total when adding a product. Check gift wrapping fees are correctly added when checking the corresponding checkbox at the end of the cart process

Important guidelines


This change is Reviewable

@prestonBot prestonBot added the develop label May 14, 2018

$computePrecision
if ($cart->gift) {
$this->wrappingFees = new AmountImmutable(
\Tools::convertPrice(

This comment has been minimized.

Copy link
@PierreRambaud

PierreRambaud May 14, 2018

Contributor

Use namespace please :)

@mickaelandrieu

This comment has been minimized.

Copy link
Member

commented May 15, 2018

Code reviewed & QA approved => LGTM

Thanks everyone!

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone May 15, 2018

@mickaelandrieu mickaelandrieu merged commit 047dfa7 into PrestaShop:develop May 15, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless changed the title fix gift wrapping fees Fix gift wrapping fees Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.