New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view shopping carts scenario #9093

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
6 participants
@fatmaBouchekoua
Contributor

fatmaBouchekoua commented May 18, 2018

Questions Answers
Branch? develop
Description? Check the cart details in the view shopping cart page.
Type? new feature
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? path=full/01_orders/5_shopping_carts_view.js npm run specific-test -- --URL=FrontOfficeUrl

This change is Reviewable

@prestonBot prestonBot added the develop label May 18, 2018

@fatmaBouchekoua fatmaBouchekoua added the TE label May 18, 2018

@marionf marionf self-requested a review May 29, 2018

@fatmaBouchekoua fatmaBouchekoua dismissed stale reviews from mbadrani and marionf via d0e18e8 Jun 21, 2018

@fatmaBouchekoua

This comment has been minimized.

Contributor

fatmaBouchekoua commented Jun 21, 2018

@mbadrani rebase done

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 28, 2018

Hi, this PR needs to be rebased.

@fatmaBouchekoua

This comment has been minimized.

Contributor

fatmaBouchekoua commented Jun 28, 2018

Done

@marionf marionf removed the QA ✔️ label Jun 28, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 28, 2018

@fatmaBouchekoua You need to review again :D

@fatmaBouchekoua

This comment has been minimized.

Contributor

fatmaBouchekoua commented Jun 28, 2018

@mbadrani review please?

@mbadrani

approved changes

@fatmaBouchekoua

This comment has been minimized.

Contributor

fatmaBouchekoua commented Jun 28, 2018

@PierreRambaud It's ready for merge !

@marionf marionf added the QA ✔️ label Jun 28, 2018

@PierreRambaud PierreRambaud merged commit 45a1ec1 into PrestaShop:develop Jun 28, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 28, 2018

Thanks @fatmaBouchekoua

@eternoendless eternoendless added this to the 1.7.5.0 milestone Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment