Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phone fieldtype #9097

Merged
merged 2 commits into from Jun 20, 2018
Merged

Fix phone fieldtype #9097

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f62ef
Fix phone filed type
rdy4ever May 19, 2018
1ea19d3
use elseif instead of if
rdy4ever May 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions classes/form/CustomerAddressFormatter.php
View file
Open in desktop
Expand Up @@ -97,6 +97,9 @@ public function getFormat()
$formField->setRequired(true);
}
}
if ($field === 'phone') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elseif or a switch statement could be better 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PierreRambaud
You are right.
elseif is better, but I don't see the need to use o a switch statement for just 2 cases.
I made another commit.

$formField->setType('tel');
}
} elseif (count($fieldParts) === 2) {
list($entity, $entityField) = $fieldParts;

Expand Down