New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit demo product and check info #9107

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
6 participants
@hadrich-hatem
Contributor

hadrich-hatem commented May 22, 2018

Questions Answers
Branch? develop
Description? This PR allows checking the basic information of demo products in the Back Office.
Type? new feature
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Run the script TEST_PATH=full/02_product/17_edit_check_demo_product_in_BO.js npm run specific-test -- --URL=FrontOfficeURL

This change is Reviewable

@prestonBot prestonBot added the develop label May 22, 2018

@fatmaBouchekoua fatmaBouchekoua added the TE label May 23, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf May 29, 2018

Contributor

Hello @hadrich-hatem

If the product is a pack, we need to check if it contains products & if the field to add product is displayed
capture du 2018-05-29 17-35-47

Contributor

marionf commented May 29, 2018

Hello @hadrich-hatem

If the product is a pack, we need to check if it contains products & if the field to add product is displayed
capture du 2018-05-29 17-35-47

@hadrich-hatem

This comment has been minimized.

Show comment
Hide comment
@hadrich-hatem

hadrich-hatem May 30, 2018

Contributor

Hello @marionf,
I have added the missing check if it contains products & if the field to add product is displayed.
Thank you.

Contributor

hadrich-hatem commented May 30, 2018

Hello @marionf,
I have added the missing check if it contains products & if the field to add product is displayed.
Thank you.

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf May 30, 2018

Contributor

Thank you @hadrich-hatem :)

Contributor

marionf commented May 30, 2018

Thank you @hadrich-hatem :)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Jun 5, 2018

Contributor

Hello @hadrich-hatem, this need to be rebased 👍

Contributor

mickaelandrieu commented Jun 5, 2018

Hello @hadrich-hatem, this need to be rebased 👍

@hadrich-hatem

This comment has been minimized.

Show comment
Hide comment
@hadrich-hatem

hadrich-hatem Jun 6, 2018

Contributor

Hello @mickaelandrieu,
The rebase of this PR done.
Best regard,

Contributor

hadrich-hatem commented Jun 6, 2018

Hello @mickaelandrieu,
The rebase of this PR done.
Best regard,

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Sep 14, 2018

Contributor

@mbadrani This PR is ready to b merged

Contributor

fatmaBouchekoua commented Sep 14, 2018

@mbadrani This PR is ready to b merged

@mbadrani

This comment has been minimized.

Show comment
Hide comment
@mbadrani

mbadrani Sep 14, 2018

Contributor

@fatmaBouchekoua some conflicts on product.js file, need rebase

Contributor

mbadrani commented Sep 14, 2018

@fatmaBouchekoua some conflicts on product.js file, need rebase

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 17, 2018

Contributor

Thanks @hadrich-hatem and everyone for reviews!

Contributor

mickaelandrieu commented Sep 17, 2018

Thanks @hadrich-hatem and everyone for reviews!

@mickaelandrieu mickaelandrieu merged commit 8ee8711 into PrestaShop:develop Sep 17, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment