New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages #9111

Merged
merged 4 commits into from Sep 14, 2018

Conversation

Projects
None yet
6 participants
@hadrich-hatem
Contributor

hadrich-hatem commented May 23, 2018

Questions Answers
Branch? develop
Description? This PR allow to: Create, Edit, Check and Delete a language in the BO. Check that the language is well created, updated and deleted in the FO. Check the RTL mode in the FO.
Type? new feature
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Run the script TEST_PATH=full/11_international/1_localization/1_create_edit_delete_language_in_BO.js npm run specific-test -- --URL=FrontOfficeURL

This change is Reviewable

@prestonBot prestonBot added the develop label May 23, 2018

@fatmaBouchekoua fatmaBouchekoua added the TE label May 23, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Jun 22, 2018

Contributor

Hello @hadrich-hatem
In checkLanguageFO, I don't see anything to check if the RTL is well in RTL (everything reversed)
Can we check that ?

Contributor

marionf commented Jun 22, 2018

Hello @hadrich-hatem
In checkLanguageFO, I don't see anything to check if the RTL is well in RTL (everything reversed)
Can we check that ?

@hadrich-hatem

This comment has been minimized.

Show comment
Hide comment
@hadrich-hatem

hadrich-hatem Jun 26, 2018

Contributor

Hello @marionf,
I have added the check of the RTL in the FO.
Can you review this PR again?
Thanks :)

Contributor

hadrich-hatem commented Jun 26, 2018

Hello @marionf,
I have added the check of the RTL in the FO.
Can you review this PR again?
Thanks :)

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Sep 14, 2018

Contributor

@mbadrani this PR is ready to be merged

Contributor

fatmaBouchekoua commented Sep 14, 2018

@mbadrani this PR is ready to be merged

@mbadrani mbadrani merged commit 1c41a40 into PrestaShop:develop Sep 14, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment