New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create attribute #9119

Merged
merged 2 commits into from Sep 20, 2018

Conversation

Projects
None yet
6 participants
@hadrich-hatem
Contributor

hadrich-hatem commented May 24, 2018

Questions Answers
Branch? develop
Description? This PR allows to do a script refactoring of the create, edit, delete and check an attribute. Create and check all type of attribute(radio, select, color and texture).
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Run the script TEST_PATH=full/04_attribute/* npm run specific-test -- --URL=FrontOfficeURL

This change is Reviewable

@hadrich-hatem

This comment has been minimized.

Show comment
Hide comment
@hadrich-hatem

hadrich-hatem Sep 19, 2018

Contributor

@mbadrani this PR is ready to be merged

Contributor

hadrich-hatem commented Sep 19, 2018

@mbadrani this PR is ready to be merged

@mbadrani

alredy approved

@mbadrani

Ready to be merged

@PierreRambaud PierreRambaud merged commit 69dd8e6 into PrestaShop:develop Sep 20, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 20, 2018

Contributor

Thanks everyone

Contributor

PierreRambaud commented Sep 20, 2018

Thanks everyone

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment