New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make commands from PrestaShop modules available in PrestaShop application #9121

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
5 participants
@mickaelandrieu
Contributor

mickaelandrieu commented May 24, 2018

Questions Answers
Branch? develop
Description? A Symfony command registered as a service in a module should be available in Symfony Console. This is a feature not really introduced in 1.7.3 that I have forgotten to finish in 1.7.4. We can imagine new business in addons, as this feature is NOT available in 1.6 :) Discussing with @eternoendless about it, it will be available in 1.7.5
Type? new feature
Category? CO
BC breaks? no
Deprecations? no
How to test? Install the following module (and enable it). Then clear the cache. Then in a terminal, try the command "php bin/console app:test". I you see "APP TEST!%" displayed, it proves it works :)

Docs

https://symfony.com/doc/3.4/console.html#creating-a-command

and

# in modules/your-module/config/services.yml
    name_of_your_command:
        class: Foo\Command\TestCommand
        tags:
            - { name: 'console.command' }

Important guidelines


This change is Reviewable

@prestonBot prestonBot added the 1.7.4.x label May 24, 2018

@mickaelandrieu mickaelandrieu changed the title from Make Symfony commands available from PrestaShop modules to Make commands from PrestaShop modules available in PrestaShop application May 24, 2018

@mickaelandrieu mickaelandrieu changed the base branch from 1.7.4.x to develop May 24, 2018

@mickaelandrieu mickaelandrieu added Code ✔️ and removed 1.7.4.x labels May 24, 2018

@prestonBot prestonBot added the develop label May 24, 2018

@eternoendless

This comment has been minimized.

Member

eternoendless commented May 28, 2018

Thank you @mickaelandrieu

@eternoendless eternoendless merged commit 2e6edcd into PrestaShop:develop May 28, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:fix-commands-from-modules branch May 28, 2018

@mickaelandrieu mickaelandrieu referenced this pull request Aug 21, 2018

Closed

Roadmap migration (1.7.5) #10

26 of 40 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment