New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the created customer in the front office and delete customer with both mode #9124

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
7 participants
@fouratachour
Contributor

fouratachour commented May 25, 2018

Questions Answers
Branch? develop
Description? This PR allows to check the created customer in the front office and delete customer with both mode
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? TEST_PATH=full/09_customer/customer_settings/* npm run specific-test -- --URL=FrontOfficeURL

This change is Reviewable

@fouratachour

This comment has been minimized.

Show comment
Hide comment
@fouratachour

fouratachour Jun 21, 2018

Contributor

Hello @marionf
This PR has been rebased
Best regard,

Contributor

fouratachour commented Jun 21, 2018

Hello @marionf
This PR has been rebased
Best regard,

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Jun 26, 2018

Contributor

@fouratachour Can you rebase please?
@fatmaBouchekoua Can you revalidate after the rebase please?

Contributor

PierreRambaud commented Jun 26, 2018

@fouratachour Can you rebase please?
@fatmaBouchekoua Can you revalidate after the rebase please?

@fouratachour

This comment has been minimized.

Show comment
Hide comment
@fouratachour

fouratachour Jun 26, 2018

Contributor

Hello @PierreRambaud
This PR has been rebased
Best regard,

Contributor

fouratachour commented Jun 26, 2018

Hello @PierreRambaud
This PR has been rebased
Best regard,

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Jun 28, 2018

Contributor

Hi, This PR needs to be rebased again due to #8827 :)

Contributor

PierreRambaud commented Jun 28, 2018

Hi, This PR needs to be rebased again due to #8827 :)

@fouratachour

This comment has been minimized.

Show comment
Hide comment
@fouratachour

fouratachour Jun 28, 2018

Contributor

Hello @PierreRambaud
Done .

Contributor

fouratachour commented Jun 28, 2018

Hello @PierreRambaud
Done .

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Jul 20, 2018

Contributor

Need rebase again cos of dependencies between your PR :(

Contributor

PierreRambaud commented Jul 20, 2018

Need rebase again cos of dependencies between your PR :(

@fouratachour

This comment has been minimized.

Show comment
Hide comment
@fouratachour

fouratachour Jul 20, 2018

Contributor

Hello @PierreRambaud
This PR has been rebased
Best regard,

Contributor

fouratachour commented Jul 20, 2018

Hello @PierreRambaud
This PR has been rebased
Best regard,

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Jul 20, 2018

Contributor

@fatmaBouchekoua for review and @marionf for QA please? :)

Contributor

PierreRambaud commented Jul 20, 2018

@fatmaBouchekoua for review and @marionf for QA please? :)

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Jul 23, 2018

Contributor

Need rebase due to a recent merge. Thinking you must do something about this, like cut common_client.js.

Contributor

PierreRambaud commented Jul 23, 2018

Need rebase due to a recent merge. Thinking you must do something about this, like cut common_client.js.

@mbadrani

The Functional scenario has been reviewed by Fourat

@fatmaBouchekoua

This comment has been minimized.

Show comment
Hide comment
@fatmaBouchekoua

fatmaBouchekoua Sep 13, 2018

Contributor

@mbadrani this PR is ready to be merged

Contributor

fatmaBouchekoua commented Sep 13, 2018

@mbadrani this PR is ready to be merged

@mbadrani mbadrani merged commit a53b1c1 into PrestaShop:develop Sep 13, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment