New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantity tests #9125

Merged
merged 6 commits into from May 30, 2018

Conversation

Projects
None yet
5 participants
@tomlev
Member

tomlev commented May 25, 2018

Questions Answers
Branch? develop
Description? adds unit tests on product adds in cart, with standard and combination products. Still missing custmizations to be complete
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? run unit tests ;)

Important guidelines


This change is Reviewable

@prestonBot prestonBot added the develop label May 25, 2018

return $this->combinations[$combinationFixtureName];
}
return null;

This comment has been minimized.

@PierreRambaud

PierreRambaud May 25, 2018

Contributor

Is it really useful?

This comment has been minimized.

@tomlev

tomlev May 25, 2018

Member

I think it is, since the array containing fixtures is only a cache, we could want to change the storage of that

@@ -0,0 +1,83 @@
<?php
/**
* 2007-2017 PrestaShop

This comment has been minimized.

@mickaelandrieu

mickaelandrieu May 25, 2018

Contributor

2018, i didnt checked other files

Configuration::set('PS_ORDER_OUT_OF_STOCK', $oldOrderOutOfStock);
}

This comment has been minimized.

@mickaelandrieu

mickaelandrieu May 25, 2018

Contributor

useless line

This comment has been minimized.

@tomlev

tomlev May 28, 2018

Member

I fixed the var definition a few lines before

@PierreRambaud

let's go fix what @mickaelandrieu report :)

tomlev added some commits May 28, 2018

requested changes were addressed

@tomlev tomlev merged commit 087b1f8 into PrestaShop:develop May 30, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless added this to the 1.7.5.0 milestone Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment