New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.php file for controllers/front/listing/ #9128

Merged
merged 5 commits into from Jun 6, 2018

Conversation

Projects
None yet
6 participants
@Seleda
Contributor

Seleda commented May 27, 2018

Questions Answers
Branch? develop
Description? index.php file for controllers/front/listing/
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? there is no index.php file

Important guidelines


This change is Reviewable

@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented May 27, 2018

Hello @Seleda!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

parent::__construct();
$this->authRedirection = $this->context->link->getPageLink($this->php_self);
}

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 May 29, 2018

Member

I guess that change wasn't wanted in this PR?

This comment has been minimized.

@Seleda

Seleda May 29, 2018

Contributor

I have thus defended some of the sites from bots that spread spam

This comment has been minimized.

@Seleda

Seleda May 29, 2018

Contributor

I deleted this fragment

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 6, 2018

@eternoendless @mickaelandrieu We maybe can merge this one without QA feedback no?

@Quetzacoalt91 Quetzacoalt91 merged commit be5532b into PrestaShop:develop Jun 6, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Jun 6, 2018

Indeed, we can merge it directly.

Thank you @Seleda

@eternoendless eternoendless added this to the 1.7.5.0 milestone Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment