New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export shopping carts scenario #9131

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
6 participants
@fatmaBouchekoua
Contributor

fatmaBouchekoua commented May 28, 2018

Questions Answers
Branch? develop
Description? This script checks if the exported file contains exactly the same information in the shopping carts table
Type? new feature
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? path=full/01_orders/6_export_shopping_carts.js npm run specific-test -- --URL=URLFrontOffice --DIR=DownloadDirectory

This change is Reviewable

@marionf

This comment has been minimized.

Contributor

marionf commented Jun 21, 2018

Hello @fatmaBouchekoua
I will review it after the the rebase & the code review :)

@marionf marionf removed the waiting for QA label Jun 21, 2018

@fatmaBouchekoua fatmaBouchekoua requested a review from mbadrani Jun 21, 2018

@mbadrani mbadrani merged commit 6ef799c into PrestaShop:develop Jun 21, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@marionf

This comment has been minimized.

Contributor

marionf commented Jun 21, 2018

@mbadrani merged without QA approved status :(

@fatmaBouchekoua

This comment has been minimized.

Contributor

fatmaBouchekoua commented Jun 21, 2018

@marionf Please check it, I will open another PR if there are missing scenarios.

@marionf

This comment has been minimized.

Contributor

marionf commented Jun 22, 2018

Seems good for me

@marionf marionf added the QA ✔️ label Jun 22, 2018

@eternoendless eternoendless added this to the 1.7.5.0 milestone Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment