New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined index on supplier page in FO #9134

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
4 participants
@marionf
Contributor

marionf commented May 28, 2018

Questions Answers
Branch? 1.7.4.x
Description? If you have a supplier without any products and try to see the supplier page in FO you will have an Undefined index: nb_products in SupplierController.php
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5626
How to test? Create a supplier, open the supplier page in FO & check if there isn't error

Important guidelines


This change is Reviewable

@prestonBot prestonBot added the 1.7.4.x label May 28, 2018

@PierreRambaud PierreRambaud added the Bug label May 28, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented May 28, 2018

Should I add a Ready for QA @marionf ? :trollface:

@marionf

This comment has been minimized.

Contributor

marionf commented May 28, 2018

Ahah, no it's already QA approved :)

@marionf marionf added the QA ✔️ label May 28, 2018

@marionf marionf added this to the 1.7.4.1 milestone May 28, 2018

@mickaelandrieu mickaelandrieu changed the title from Fix undifined index on supplier page in FO to Fix undefined index on supplier page in FO May 28, 2018

@eternoendless eternoendless modified the milestones: 1.7.4.1, 1.7.4.0 May 29, 2018

@eternoendless

This comment has been minimized.

Member

eternoendless commented May 29, 2018

Thank you @marionf

@eternoendless eternoendless merged commit d03aade into PrestaShop:1.7.4.x May 29, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment