New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notice on brands page #9138

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
6 participants
@SebBareyre
Contributor

SebBareyre commented May 29, 2018

Questions Answers
Branch? 1.7.4.x
Description? Fix notice Undefined index: nb_products on brands page if there is no products linked to any manufacturer
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? BOOM-2663
How to test? visit brands page with at least a brand but without any products linked to a brand

This change is Reviewable

[FO] Fix notice on brands page
Fix notice on brands page if there is no products linked to any manufacturer

@prestonBot prestonBot added the 1.7.4.x label May 29, 2018

@mickaelandrieu mickaelandrieu added the Bug label May 29, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.4.1 milestone May 29, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels May 29, 2018

@PierreRambaud PierreRambaud merged commit a3e72f3 into PrestaShop:1.7.4.x Jun 28, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 28, 2018

Thanks @SebBareyre

@eternoendless eternoendless changed the title from [FO] Fix notice on brands page to Fix notice on brands page Jul 10, 2018

@PierreRambaud PierreRambaud modified the milestones: 1.7.4.1, 1.7.4.0 Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment