New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer dependencies #9140

Merged
merged 3 commits into from May 31, 2018

Conversation

Projects
None yet
5 participants
@mickaelandrieu
Contributor

mickaelandrieu commented May 29, 2018

Questions Answers
Branch? develop
Description? Updating our deps provide us all bug fixes of our ecosystem and specifically, I need to be able to prefix a collection of routes. This feature has been fixed in 3.4.11 afaik. Updating our stack I've also met a bug from Smarty, that log a warning when passing a Smarty instance as a reference and not as value. I've also met a weird issue the first time I tried to log in into the back office, when a generic Welcome page that comes from HttpKernel component and this behavior was introduced in 3.4.6. As I can't reproduce this issue right now, I guess it's ok but this is something we should merge early in release process so we can fix it as early as possible.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? yes, Smarty doesn't want Smarty instance to be passed as references in registered functions.
How to test? Tests should pass and display should be the same.

Important guidelines


This change is Reviewable

@prestonBot prestonBot added the develop label May 29, 2018

@mickaelandrieu mickaelandrieu added the Bug label May 29, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone May 29, 2018

@eternoendless eternoendless changed the title from Update dependencies to Update composer dependencies May 30, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented May 31, 2018

@PierreRambaud check this out, I had to rebase it

@Quetzacoalt91 Quetzacoalt91 merged commit f75b873 into PrestaShop:develop May 31, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:update-deps branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment