New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding review page check #9148

Merged
merged 1 commit into from Jun 29, 2018

Conversation

Projects
None yet
7 participants
@fouratachour
Contributor

fouratachour commented May 31, 2018

Questions Answers
Branch? develop
Description? This PR allows to check the created page Preview
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? Run the script path=full/15_design/2_pages/* npm run specific-test -- --URL=BackOfficeURL

This change is Reviewable

@prestonBot prestonBot added the develop label May 31, 2018

@fouratachour fouratachour changed the title from TE: Adding review page check to Adding review page check Jun 1, 2018

@fouratachour

This comment has been minimized.

Contributor

fouratachour commented Jun 21, 2018

Hello @marionf
This PR has been rebased
Best regard,

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 28, 2018

This PR need to be rebased again :)

@fouratachour

This comment has been minimized.

Contributor

fouratachour commented Jun 28, 2018

@PierreRambaud PierreRambaud merged commit c86ecf3 into PrestaShop:develop Jun 29, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 29, 2018

Thanks @fouratachour

@eternoendless eternoendless added this to the 1.7.5.0 milestone Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment