New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with quota fields #9149

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
5 participants
@PierreRambaud
Contributor

PierreRambaud commented May 31, 2018

Questions Answers
Branch? 1.7.4.x
Description? We mustn't be able to set a empty value. More only check for array_key_exists instead of array_keys([], true) which remove keys with empty value and there is a difference between file and post data.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5631
How to test? Try to set "0" in upload quota fields.

This change is Reviewable

Error with quota fields
We mustn't be able to set a empty value. More only check for
array_key_exists instead of array_keys([], true) which remove keys with
empty value.

@marionf marionf added this to the 1.7.4.0 milestone May 31, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Jun 1, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit abbb127 into PrestaShop:develop Jun 1, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Jun 1, 2018

Thank you @PierreRambaud

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/boom-5631 branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment