New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile for single container run of E2E #9150

Merged
merged 2 commits into from Jun 18, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented May 31, 2018

Questions Answers
Branch? develop
Description? Add a Dockerfile for E2E tests, which can be used for automated builds
Type? new feature
Category? TE
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Please follow the information provided in the README.md

This change is Reviewable

@prestonBot prestonBot added the develop label May 31, 2018

@Quetzacoalt91 Quetzacoalt91 changed the title from Add dockerfile for single container runner to Add dockerfile for single container run of E2E May 31, 2018

cd /var/www/html/tests/E2E
npm install --unsafe-perm \

This comment has been minimized.

@PierreRambaud

PierreRambaud May 31, 2018

Contributor

Double space, and maybe add npm install -g npm?

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 May 31, 2018

Member

Why do you need npm install -g npm for?

This comment has been minimized.

@PierreRambaud

PierreRambaud May 31, 2018

Contributor

make sure npm is the latest version =)

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 May 31, 2018

Member

This file is called in the Dockerfile, and we have that command a few lines before:

  && npm i npm@latest -g \

This would be a duplicate. :)

This comment has been minimized.

@PierreRambaud

PierreRambaud Jun 1, 2018

Contributor

Huhu doesn't saw it 👍

&& apt install -y software-properties-common python-software-properties \
# nodejs
&& apt install -y nodejs \
&& npm i npm@latest -g \

This comment has been minimized.

@PierreRambaud

PierreRambaud May 31, 2018

Contributor

no need this spaces.

&& rm /tmp/oracle-license-debconf \
&& apt install -y oracle-java8-installer \
oracle-java8-set-default \
# chrome dependancies

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Jun 4, 2018

Contributor

dependencies

> **HEADLESS**: **(Optional)** Set it to true to run tests in headless mode (default to false)
## Running the tests with Docker

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Jun 4, 2018

Contributor

Thanks for the documentation, this will help contributors :)

@mickaelandrieu mickaelandrieu merged commit da03536 into PrestaShop:develop Jun 18, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 18, 2018

@eternoendless eternoendless added this to the 1.7.5.0 milestone Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment