New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 500 while getting order total #9160

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
6 participants
@PierreRambaud
Contributor

PierreRambaud commented Jun 4, 2018

Questions Answers
Branch? 1.7.4.x
Description? Recursive call while selecting cart rule
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-5659
How to test? Everything is defined in the forge ticket :)

This change is Reviewable

@prestonBot prestonBot added the 1.7.4.x label Jun 4, 2018

@PierreRambaud PierreRambaud added the Bug label Jun 4, 2018

@tomlev

tomlev approved these changes Jun 4, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Jun 5, 2018

@PierreRambaud PierreRambaud added this to the 1.7.4.0 milestone Jun 5, 2018

@eternoendless

This comment has been minimized.

Member

eternoendless commented Jun 5, 2018

Thank you @PierreRambaud

@eternoendless eternoendless merged commit 877e2e8 into PrestaShop:1.7.4.x Jun 5, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/boom-5659 branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment