New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless line for meta_title #9162

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
5 participants
@lfluvisotto
Contributor

lfluvisotto commented Jun 4, 2018

Questions Answers
Branch? develop
Description? The left and the right parts of assignment are equal
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? No test needed

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 5, 2018

Ping @eternoendless can I merge this pull request directly, we have a weird issue with Travis ...

@Quetzacoalt91

Indeed, thank you @lfluvisotto

@Quetzacoalt91 Quetzacoalt91 merged commit 8ad48db into PrestaShop:develop Jun 5, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
code-review/reviewable 1 file reviewed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Jun 5, 2018

As suggested by @mickaelandrieu, we can merge directly.

@eternoendless eternoendless added this to the 1.7.5.0 milestone Jun 6, 2018

@jolelievre jolelievre changed the title from CO: The left and the right parts of assignment are equal to Remove useless line for meta_title Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment