New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case mismatch in class/function/method call #9163

Merged
merged 1 commit into from Jun 5, 2018

Conversation

Projects
None yet
4 participants
@lfluvisotto
Contributor

lfluvisotto commented Jun 4, 2018

Questions Answers
Branch? develop
Description? Case mismatch in class/function/method call
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Surf in any page of the store

This change is Reviewable

@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Jun 4, 2018

Hello @lfluvisotto!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PrestaShop PrestaShop deleted a comment from prestonBot Jun 5, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 5, 2018

Hello @lfluvisotto,

thanks for your first contribution! I'm wondering, how did you do to find all those mismatch? Did you use some linters for instance? We may add it to travis 👍

Mickaël

@mickaelandrieu mickaelandrieu merged commit f565c9f into PrestaShop:develop Jun 5, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
code-review/reviewable 56 files reviewed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lfluvisotto

This comment has been minimized.

Contributor

lfluvisotto commented Jun 5, 2018

@mickaelandrieu PhpStorm + PHP CodeSniffer + PHP Mess Detector + Tools in here > https://phpqa.io

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 5, 2018

Great! if you want to fix others code smells, you are very welcome 👍

@eternoendless eternoendless added this to the 1.7.5.0 milestone Jun 6, 2018

@jolelievre jolelievre changed the title from CO: Case mismatch in class/function/method call to Case mismatch in class/function/method call Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment