New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed namespace of Delivery Slips controller #9171

Merged
merged 1 commit into from Jun 7, 2018

Conversation

Projects
None yet
5 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Jun 6, 2018

Questions Answers
Branch? develop
Description? self described
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Nothing, if tests pass: you can merge

Important guidelines


This change is Reviewable

@prestonBot prestonBot added the develop label Jun 6, 2018

@mickaelandrieu mickaelandrieu added the Bug label Jun 6, 2018

@sarjon

This comment has been minimized.

Member

sarjon commented Jun 6, 2018

maybe form namespace should be fixed as well? from PrestaShopBundle\Form\Admin\Order\Delivery to PrestaShopBundle\Form\Admin\Sell\Orders\DeliverySlips ?

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 6, 2018

We can have many Delivery things, I think it's better to cut name the more as possible.

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 6, 2018

ping @PierreRambaud would you mind approving this contribution? I've addressed your comments 👍

Thanks @sarjon for the review!

@mickaelandrieu mickaelandrieu merged commit a02e990 into PrestaShop:develop Jun 7, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:change-namespace branch Jun 7, 2018

@mickaelandrieu

This comment has been minimized.

Contributor

mickaelandrieu commented Jun 7, 2018

And merged, no need QA team for a namespace renaming 👍

@eternoendless eternoendless added this to the 1.7.5.0 milestone Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment