New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-remove carrier-specific voucher when changing carrier #9172

Merged
merged 4 commits into from Jun 28, 2018

Conversation

Projects
None yet
4 participants
@tomlev
Member

tomlev commented Jun 6, 2018

Questions Answers
Branch? 1.7.4.x
Description? Fix auto-remove carrier-specific voucher when changing carrier
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? http://forge.prestashop.com/browse/BOOM-3307 http://forge.prestashop.com/browse/BOOM-5218 http://forge.prestashop.com/browse/BOOM-5219
How to test? Add a carrier-specific voucher. Check voucher is automatically removed when changing carrier. Test the same behavior with empty-code voucher

Important guidelines


This change is Reviewable

@tomlev

This comment has been minimized.

Member

tomlev commented Jun 6, 2018

same as #9142

@tomlev tomlev changed the title from Boom 5219 2 to Fix auto-remove carrier-specific voucher when changing carrier Jun 6, 2018

@marionf marionf added the QA ✔️ label Jun 6, 2018

@marionf marionf added this to the 1.7.4.1 milestone Jun 6, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 6, 2018

Your PR #9142 doesn't include smarty fix, is it normal to have this one in this PR?

@tomlev tomlev added the Bug label Jun 7, 2018

@tomlev

This comment has been minimized.

Member

tomlev commented Jun 7, 2018

smarty fix was required by QA to test this PR, and is already merged in develop

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 7, 2018

So I approve it again! :)

@PierreRambaud PierreRambaud merged commit 745b34d into PrestaShop:1.7.4.x Jun 28, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Jun 28, 2018

Thansk @tomlev

@PierreRambaud PierreRambaud modified the milestones: 1.7.4.1, 1.7.4.0 Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment